Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torchlib] Implement aten::prelu #1728

Merged
merged 5 commits into from
Jul 11, 2024
Merged

[torchlib] Implement aten::prelu #1728

merged 5 commits into from
Jul 11, 2024

Conversation

justinchuby
Copy link
Collaborator

No description provided.

@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jul 11, 2024
@justinchuby justinchuby mentioned this pull request Jul 11, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (54537e4) to head (144bf6d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
+ Coverage   74.69%   74.88%   +0.19%     
==========================================
  Files         242      242              
  Lines       25862    25869       +7     
  Branches     4662     4665       +3     
==========================================
+ Hits        19317    19373      +56     
+ Misses       5676     5627      -49     
  Partials      869      869

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Test Results

     24 files  ±     0      24 suites  ±0   3h 4m 35s ⏱️ - 10m 11s
 11 839 tests + 2 170   9 721 ✅ +1 554    2 087 💤 +   611   31 ❌ +  5 
452 752 runs   - 17 241  95 456 ✅  - 2 604  356 885 💤  - 14 822  411 ❌ +185 

For more details on these failures, see this check.

Results for commit 9325070. ± Comparison against base commit 54537e4.

This pull request removes 296 and adds 2466 tests. Note that renamed tests count towards both. 
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_204_aten_rand
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_205_aten_rand_like
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_206_aten_randint
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_207_aten_randint_low
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_208_aten_randint_like
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_209_aten_randint_like_low_dtype
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_210_aten_randn
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_211_aten_randn_like
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_212_aten_rad2deg
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_213_aten_reciprocal
…

onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_basic_defs
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_doc_string
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_if_defs
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_if_loop_defs
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_loop_defs
onnxscript._internal.analysis_test.TestExposedUses ‑ test_basic
onnxscript._internal.analysis_test.TestExposedUses ‑ test_called_function
onnxscript._internal.analysis_test.TestExposedUses ‑ test_doc_string
onnxscript._internal.analysis_test.TestExposedUses ‑ test_for_loop
onnxscript._internal.analysis_test.TestExposedUses ‑ test_if
…
This pull request removes 93 skipped tests and adds 704 skipped tests. Note that renamed tests count towards both. 
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_204_aten_rand
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_205_aten_rand_like
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_206_aten_randint
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_207_aten_randint_low
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_208_aten_randint_like
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_209_aten_randint_like_low_dtype
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_210_aten_randn
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_211_aten_randn_like
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_217_aten_resolve_conj
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_218_aten_resolve_neg
…

onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0001_test_acos
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0002_test_acosh
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0003_test_acosh_example
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0004_test_acos_example
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0005_test_adagrad
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0006_test_adagrad_multiple
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0007_test_adam
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0008_test_adam_multiple
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0011_test_add_uint8
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0020_test_ai_onnx_ml_array_feature_extractor
…

@justinchuby justinchuby merged commit c06e7ab into main Jul 11, 2024
31 of 42 checks passed
@justinchuby justinchuby deleted the justinchu/prelu branch July 11, 2024 18:30
@titaiwangms
Copy link
Contributor

titaiwangms commented Aug 19, 2024 •
edited
Loading

Is there a reason we don't use ONNX PRelu? https://github.com/onnx/onnx/blob/main/docs/Operators.md#PRelu. I found this from the difference between torchscript and torch-onnx graph.

@justinchuby
Copy link
Collaborator Author

I didn't know it existed. I will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

Assignees
No one assigned
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
ONNX Script Review Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinchuby @titaiwangms